From: Thomas Graf <tgraf@suug.ch>
To: Tom Herbert <therbert@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] vxlan: Eliminate dependency on UDP socket in transmit path
Date: Mon, 19 Jan 2015 08:59:38 +0000 [thread overview]
Message-ID: <20150119085938.GG20315@casper.infradead.org> (raw)
In-Reply-To: <1421518700-22460-3-git-send-email-therbert@google.com>
On 01/17/15 at 10:18am, Tom Herbert wrote:
> diff --git a/include/net/vxlan.h b/include/net/vxlan.h
> index 7be8c34..2927d62 100644
> --- a/include/net/vxlan.h
> +++ b/include/net/vxlan.h
> @@ -129,8 +129,12 @@ struct vxlan_sock {
> #define VXLAN_F_REMCSUM_RX 0x400
> #define VXLAN_F_GBP 0x800
>
> -/* These flags must match in order for a socket to be shareable */
> -#define VXLAN_F_UNSHAREABLE VXLAN_F_GBP
> +/* Flags that are used in the receive patch. These flags must match in
^^^^^
> + * order for a socket to be shareable
> + */
> +#define VXLAN_F_RCV_FLAGS (VXLAN_F_GBP | \
> + VXLAN_F_UDP_ZERO_CSUM6_RX | \
> + VXLAN_F_REMCSUM_RX)
I'm fine with this. It is slightly odd that we will be transmitting
RCO and other extensions on UDP ports which cannot accept the same
frames. I assume you have specific use cases for this scenario.
next prev parent reply other threads:[~2015-01-19 8:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 18:18 [PATCH net-next 0/2] vxlan: Don't use UDP socket for transmit Tom Herbert
2015-01-17 18:18 ` [PATCH net-next 1/2] udp: Do not require sock in udp_tunnel_xmit_skb Tom Herbert
2015-01-17 23:45 ` Jesse Gross
2015-01-18 22:43 ` Or Gerlitz
2015-01-20 17:36 ` Tom Herbert
2015-01-20 21:47 ` Or Gerlitz
2015-01-20 22:24 ` Tom Herbert
2015-01-21 20:57 ` Or Gerlitz
2015-01-21 22:24 ` Tom Herbert
2015-01-21 22:37 ` Or Gerlitz
2015-01-21 22:55 ` Tom Herbert
2015-01-17 18:18 ` [PATCH net-next 2/2] vxlan: Eliminate dependency on UDP socket in transmit path Tom Herbert
2015-01-19 8:59 ` Thomas Graf [this message]
2015-01-20 17:29 ` Tom Herbert
2015-01-20 18:13 ` Thomas Graf
2015-01-20 22:53 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119085938.GG20315@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).