Netdev List
 help / color / mirror / Atom feed
From: Ignacy Gawedzki <ignacy.gawedzki@green-communications.fr>
To: netdev@vger.kernel.org
Cc: Patrick McHardy <kaber@trash.net>,
	Stephen Hemminger <shemminger@linux-foundation.org>
Subject: iproute2 and kernel clock resolutions
Date: Wed, 21 Jan 2015 14:22:36 +0100	[thread overview]
Message-ID: <20150121132236.GA28397@zenon.in.qult.net> (raw)

Hi,

While reading tc/tc_core.c, I'm having a hard time making sense of what
tc_core_init() is actually supposed to do.

It looks just as if clock_res is not filled with the correct value from
/proc/net/psched, taking into account the "compatibility hack" that follows.
AFAICT from the historical kernel Git repository, the third value in
/proc/net/psched has always been hardcoded as 1000000, so it seems that the
condition clock_res == 1000000000 is always false.  Shouldn't clock_res be
filled with the fourth value instead of the third, by any chance?

Could also anyone explain to me what this hack is actually about?

Thanks,

Ignacy

-- 
Ignacy Gawędzki
R&D Engineer
Green Communications

                 reply	other threads:[~2015-01-21 13:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150121132236.GA28397@zenon.in.qult.net \
    --to=ignacy.gawedzki@green-communications.fr \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox