From: Erik Hugne <erik.hugne@ericsson.com>
To: Joe Perches <joe@perches.com>
Cc: <richard.alpe@ericsson.com>, <netdev@vger.kernel.org>,
<jon.maloy@ericsson.com>, <ying.xue@windriver.com>,
<tipc-discussion@lists.sourceforge.net>
Subject: Re: [PATCH net-next 1/2] tipc: fix excessive network event logging
Date: Fri, 23 Jan 2015 07:44:30 +0100 [thread overview]
Message-ID: <20150123064430.GA26059@haze> (raw)
In-Reply-To: <1421947487.2702.1.camel@perches.com>
On Thu, Jan 22, 2015 at 09:24:47AM -0800, Joe Perches wrote:
> On Thu, 2015-01-22 at 17:10 +0100, erik.hugne@ericsson.com wrote:
> > From: Erik Hugne <erik.hugne@ericsson.com>
> >
> > If a large number of namespaces is spawned on a node and TIPC is
> > enabled in each of these, the excessive printk tracing of network
> > events will cause the system to grind down to a near halt.
> > The traces are still of debug value, so instead of removing them
> > completely we fix it by changing the link state and node availability
> > logging debug traces.
>
> Maybe some of these should be net_<level>_ratelimited(fmt, ...)
We proposed that initially, but changed all to pr_debug after David's comment:
http://www.spinics.net/lists/netdev/msg312902.html
The topology information (links going up/down) can be accessed
both via netlink ('tipc link list' command) and the topology server
via a subscription API.
//E
next prev parent reply other threads:[~2015-01-23 6:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 16:10 [PATCH net-next 1/2] tipc: fix excessive network event logging erik.hugne
2015-01-22 16:10 ` [PATCH net-next 2/2] flow_dissector: add tipc support erik.hugne
2015-01-22 17:29 ` Eric Dumazet
2015-01-22 18:38 ` Jon Maloy
2015-01-27 0:57 ` David Miller
2015-01-27 12:08 ` Erik Hugne
2015-01-27 14:40 ` Eric Dumazet
2015-01-27 1:04 ` David Miller
2015-01-22 17:24 ` [PATCH net-next 1/2] tipc: fix excessive network event logging Joe Perches
2015-01-23 6:44 ` Erik Hugne [this message]
2015-01-27 1:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123064430.GA26059@haze \
--to=erik.hugne@ericsson.com \
--cc=joe@perches.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=richard.alpe@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).