From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 2/2] bnx2x: fix napi poll return value for repoll Date: Sat, 24 Jan 2015 22:40:04 -0800 (PST) Message-ID: <20150124.224004.1215346085544777165.davem@davemloft.net> References: <1421759776-376-1-git-send-email-_govind@gmx.com> <1421759776-376-3-git-send-email-_govind@gmx.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, ariel.elior@qlogic.com, ssujith@cisco.com, benve@cisco.com To: _govind@gmx.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:60338 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911AbbAYGkF (ORCPT ); Sun, 25 Jan 2015 01:40:05 -0500 In-Reply-To: <1421759776-376-3-git-send-email-_govind@gmx.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Govindarajulu Varadarajan <_govind@gmx.com> Date: Tue, 20 Jan 2015 18:46:16 +0530 > With the commit d75b1ade567ffab ("net: less interrupt masking in NAPI") napi repoll > is done only when work_done == budget. When in busy_poll is we return 0 in > napi_poll. We should return budget. Also do not return workdone > budget. > > Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com> This seems like it needs some adjustments, please make those corrections and respin this patch. Thanks.