From: David Miller <davem@davemloft.net>
To: maheshb@google.com
Cc: netdev@vger.kernel.org, edumazet@google.com, dan.carpenter@oracle.com
Subject: Re: [PATCH net] ipvlan: fix incorrect usage of IS_ERR() macro in IPv6 code path.
Date: Sun, 25 Jan 2015 00:24:45 -0800 (PST) [thread overview]
Message-ID: <20150125.002445.702364447839790923.davem@davemloft.net> (raw)
In-Reply-To: <1422165223-13496-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Sat, 24 Jan 2015 21:53:43 -0800
> The ip6_route_output() always returns a valid dst pointer unlike in IPv4
> case. So the validation has to be different from the IPv4 path. Correcting
> that error in this patch.
>
> This was picked up by a static checker with a following warning -
>
> drivers/net/ipvlan/ipvlan_core.c:380 ipvlan_process_v6_outbound()
> warn: 'dst' isn't an ERR_PTR
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
prev parent reply other threads:[~2015-01-25 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-25 5:53 [PATCH net] ipvlan: fix incorrect usage of IS_ERR() macro in IPv6 code path Mahesh Bandewar
2015-01-25 8:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150125.002445.702364447839790923.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=edumazet@google.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox