From: David Miller <davem@davemloft.net>
To: noureddine@arista.com
Cc: edumazet@google.com, therbert@google.com, jiri@resnulli.us,
vyasevic@redhat.com, netdev@vger.kernel.org,
ebiederm@xmission.com
Subject: Re: [PATCH 1/1 net-next] dev: add per net_device packet type chains
Date: Tue, 27 Jan 2015 00:02:01 -0800 (PST) [thread overview]
Message-ID: <20150127.000201.1561369463873997294.davem@davemloft.net> (raw)
In-Reply-To: <1422043643-3265-1-git-send-email-noureddine@arista.com>
From: Salam Noureddine <noureddine@arista.com>
Date: Fri, 23 Jan 2015 12:07:23 -0800
> /* deliver only exact match when indicated */
> - null_or_dev = deliver_exact ? skb->dev : NULL;
> + if (likely(!deliver_exact)) {
> + deliver_ptype_list_skb(skb, &pt_prev, orig_dev, type,
> + &ptype_base[ntohs(type) & PTYPE_HASH_MASK]);
> + }
This is not indented properly.
A call that spans multiple lines should have the arguments on the
second and subsequent lines begin precisely at the first column
after the openning parenthesis on the first line.
Please fix this up and resubmit.
prev parent reply other threads:[~2015-01-27 8:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 20:07 [PATCH 1/1 net-next] dev: add per net_device packet type chains Salam Noureddine
2015-01-27 8:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127.000201.1561369463873997294.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=noureddine@arista.com \
--cc=therbert@google.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox