From: David Miller <davem@davemloft.net>
To: der.herr@hofr.at
Cc: devel@linuxdriverproject.org, haiyangz@microsoft.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: hyperv: else branch not necessary
Date: Tue, 27 Jan 2015 00:10:29 -0800 (PST) [thread overview]
Message-ID: <20150127.001029.277347255719163174.davem@davemloft.net> (raw)
In-Reply-To: <1422209317-18975-1-git-send-email-der.herr@hofr.at>
From: Nicholas Mc Guire <der.herr@hofr.at>
Date: Sun, 25 Jan 2015 19:08:37 +0100
> As the if completes with a unconditional goto the else branch
> is not needed here.
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
>
> v2: added missing subsystem string in subject line - patch unchanged
The feedback you were given was completely bogus.
Saying "net: " in addition to "hyperv: " is unnecessary, redundant,
and something you should not do.
Just plain "hyperv: " is complete and unambiguous enough to stand
upon itself.
Nobody says "net: ixgbe: " for Intel ethernet driver changes. That's
just stupid.
prev parent reply other threads:[~2015-01-27 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-25 18:08 [PATCH v2] net: hyperv: else branch not necessary Nicholas Mc Guire
2015-01-26 22:47 ` Haiyang Zhang
2015-01-27 8:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127.001029.277347255719163174.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=der.herr@hofr.at \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).