From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2] net: hyperv: else branch not necessary Date: Tue, 27 Jan 2015 00:10:29 -0800 (PST) Message-ID: <20150127.001029.277347255719163174.davem@davemloft.net> References: <1422209317-18975-1-git-send-email-der.herr@hofr.at> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: devel@linuxdriverproject.org, haiyangz@microsoft.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: der.herr@hofr.at Return-path: In-Reply-To: <1422209317-18975-1-git-send-email-der.herr@hofr.at> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org From: Nicholas Mc Guire Date: Sun, 25 Jan 2015 19:08:37 +0100 > As the if completes with a unconditional goto the else branch > is not needed here. > > Signed-off-by: Nicholas Mc Guire > --- > > v2: added missing subsystem string in subject line - patch unchanged The feedback you were given was completely bogus. Saying "net: " in addition to "hyperv: " is unnecessary, redundant, and something you should not do. Just plain "hyperv: " is complete and unambiguous enough to stand upon itself. Nobody says "net: ixgbe: " for Intel ethernet driver changes. That's just stupid.