* [PATCH net v2] bnx2x: fix napi poll return value for repoll
@ 2015-01-25 10:39 Govindarajulu Varadarajan
2015-01-25 16:05 ` Eric Dumazet
2015-01-27 8:29 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Govindarajulu Varadarajan @ 2015-01-25 10:39 UTC (permalink / raw)
To: davem, netdev, ariel.elior; +Cc: edumazet, Govindarajulu Varadarajan
With the commit d75b1ade567ffab ("net: less interrupt masking in NAPI") napi
repoll is done only when work_done == budget. When in busy_poll is we return 0
in napi_poll. We should return budget.
Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
---
v2:
Remove unnecessary change for work_done >= budget return value.
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
index 1d1147c..e468ed3 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
@@ -3175,7 +3175,7 @@ static int bnx2x_poll(struct napi_struct *napi, int budget)
}
#endif
if (!bnx2x_fp_lock_napi(fp))
- return work_done;
+ return budget;
for_each_cos_in_tx_queue(fp, cos)
if (bnx2x_tx_queue_has_work(fp->txdata_ptr[cos]))
--
2.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net v2] bnx2x: fix napi poll return value for repoll
2015-01-25 10:39 [PATCH net v2] bnx2x: fix napi poll return value for repoll Govindarajulu Varadarajan
@ 2015-01-25 16:05 ` Eric Dumazet
2015-01-27 8:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2015-01-25 16:05 UTC (permalink / raw)
To: Govindarajulu Varadarajan; +Cc: davem, netdev, ariel.elior, edumazet
On Sun, 2015-01-25 at 16:09 +0530, Govindarajulu Varadarajan wrote:
> With the commit d75b1ade567ffab ("net: less interrupt masking in NAPI") napi
> repoll is done only when work_done == budget. When in busy_poll is we return 0
> in napi_poll. We should return budget.
>
> Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
> ---
> v2:
> Remove unnecessary change for work_done >= budget return value.
>
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> index 1d1147c..e468ed3 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> @@ -3175,7 +3175,7 @@ static int bnx2x_poll(struct napi_struct *napi, int budget)
> }
> #endif
> if (!bnx2x_fp_lock_napi(fp))
> - return work_done;
> + return budget;
>
> for_each_cos_in_tx_queue(fp, cos)
> if (bnx2x_tx_queue_has_work(fp->txdata_ptr[cos]))
Thanks !
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net v2] bnx2x: fix napi poll return value for repoll
2015-01-25 10:39 [PATCH net v2] bnx2x: fix napi poll return value for repoll Govindarajulu Varadarajan
2015-01-25 16:05 ` Eric Dumazet
@ 2015-01-27 8:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-01-27 8:29 UTC (permalink / raw)
To: _govind; +Cc: netdev, ariel.elior, edumazet
From: Govindarajulu Varadarajan <_govind@gmx.com>
Date: Sun, 25 Jan 2015 16:09:23 +0530
> With the commit d75b1ade567ffab ("net: less interrupt masking in NAPI") napi
> repoll is done only when work_done == budget. When in busy_poll is we return 0
> in napi_poll. We should return budget.
>
> Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-27 8:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-25 10:39 [PATCH net v2] bnx2x: fix napi poll return value for repoll Govindarajulu Varadarajan
2015-01-25 16:05 ` Eric Dumazet
2015-01-27 8:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).