From: Jack Morgenstein <jackm@dev.mellanox.co.il>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Amir Vadai' <amirv@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Or Gerlitz <ogerlitz@mellanox.com>,
Yevgeny Petrilin <yevgenyp@mellanox.com>
Subject: Re: [PATCH net-next V1 04/11] net/mlx4_core: Adjust command timeouts to conform to the firmware spec
Date: Tue, 27 Jan 2015 20:06:42 +0200 [thread overview]
Message-ID: <20150127200642.441db19f@jpm-OptiPlex-GX620> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CAD3EAA@AcuExch.aculab.com>
On Tue, 27 Jan 2015 14:30:31 +0000
David Laight <David.Laight@ACULAB.COM> wrote:
> From: Amir Vadai
> > From: Jack Morgenstein <jackm@dev.mellanox.co.il>
> >
> > The firmware spec states that the timeout for all commands should
> > be 60 seconds.
>
> Hmmm... 60 seconds seems a long time to wait for a device to do
> something.
>
> I'll have given up and reset the machine before that expires.
>
> David
>
We have some automatic recovery features which involve resetting the
HCA upon command timeout, and we purposely give a long timeout
in order to be sure that there are no false positives
(i.e., unjustified resets).
-Jack
next prev parent reply other threads:[~2015-01-27 18:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 13:57 [PATCH net-next V1 00/11] Mellanox ethernet driver updates Jan-27-2015 Amir Vadai
2015-01-27 13:57 ` [PATCH net-next V1 01/11] net/mlx4_core: Add bad-cable event support Amir Vadai
2015-01-27 13:58 ` [PATCH net-next V1 02/11] net/mlx4_core: Add reserved lkey for VFs to QUERY_FUNC_CAP Amir Vadai
2015-01-27 13:58 ` [PATCH net-next V1 03/11] net/mlx4_core: Fix mem leak in SRIOV mlx4_init_one error flow Amir Vadai
2015-01-27 13:58 ` [PATCH net-next V1 04/11] net/mlx4_core: Adjust command timeouts to conform to the firmware spec Amir Vadai
2015-01-27 14:30 ` David Laight
2015-01-27 18:06 ` Jack Morgenstein [this message]
2015-01-27 13:58 ` [PATCH net-next V1 05/11] net/mlx4_core: Fix HW2SW_EQ " Amir Vadai
2015-01-27 13:58 ` [PATCH net-next V1 06/11] net/mlx4_core: Fix struct mlx4_vhcr_cmd to make implicit padding explicit Amir Vadai
2015-01-27 13:58 ` [PATCH net-next V1 07/11] net/mlx4_core: Remove duplicate code line from procedure mlx4_bf_alloc Amir Vadai
2015-01-27 13:58 ` [PATCH net-next V1 08/11] net/mlx4_en: Use ethtool cmd->autoneg as a hint for ethtool set settings Amir Vadai
2015-01-27 13:58 ` [PATCH net-next V1 09/11] net/mlx4: Fix memory corruption in mlx4_MAD_IFC_wrapper Amir Vadai
2015-01-27 13:58 ` [PATCH net-next V1 10/11] net/mlx4_core: Fix device capabilities dumping Amir Vadai
2015-01-27 13:58 ` [PATCH net-next V1 11/11] net/mlx4_core: Update the HCA core clock frequency after INIT_PORT Amir Vadai
2015-01-28 1:13 ` [PATCH net-next V1 00/11] Mellanox ethernet driver updates Jan-27-2015 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127200642.441db19f@jpm-OptiPlex-GX620 \
--to=jackm@dev.mellanox.co.il \
--cc=David.Laight@ACULAB.COM \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox