From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: david.stevens@oracle.com, netdev@vger.kernel.org,
sowmini.varadhan@oracle.com
Subject: Re: [PATCHv2 net] sunvnet: set queue mapping when doing packet copies
Date: Thu, 29 Jan 2015 14:15:58 -0800 (PST) [thread overview]
Message-ID: <20150129.141558.2191091565448535105.davem@davemloft.net> (raw)
In-Reply-To: <1422563996.21689.26.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 29 Jan 2015 12:39:56 -0800
> On Thu, 2015-01-29 at 14:42 -0500, David L Stevens wrote:
>> @@ -1123,6 +1123,16 @@ static inline struct sk_buff *vnet_skb_shape(struct sk_buff *skb, int ncookies)
>> skb_shinfo(nskb)->gso_size = skb_shinfo(skb)->gso_size;
>> skb_shinfo(nskb)->gso_type = skb_shinfo(skb)->gso_type;
>> }
>> + nskb->queue_mapping = skb->queue_mapping;
>> + /* Following permits correct back-pressure, for protocols
>> + * using skb_set_owner_w().
>> + * Idea is to transfer ownership from skb to nskb.
>> + */
>> + if (skb->destructor == sock_wfree) {
>
> Sorry, but you should remove this test.
>
> (TCP uses another destructor, not sock_wfree())
>
> All sent packets will support these swap() operations,
> regardless of destructor.
Then we need to fix skb_segment() too.
next prev parent reply other threads:[~2015-01-29 22:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 19:42 [PATCHv2 net] sunvnet: set queue mapping when doing packet copies David L Stevens
2015-01-29 20:39 ` Eric Dumazet
2015-01-29 21:36 ` David L Stevens
2015-01-29 22:19 ` Eric Dumazet
2015-01-29 22:22 ` Eric Dumazet
2015-01-29 22:15 ` David Miller [this message]
2015-01-29 22:30 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150129.141558.2191091565448535105.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.stevens@oracle.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sowmini.varadhan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).