From: David Miller <davem@davemloft.net>
To: hariprasad@chelsio.com
Cc: netdev@vger.kernel.org, leedom@chelsio.com, anish@chelsio.com,
nirranjan@chelsio.com, praveenm@chelsio.com
Subject: Re: [PATCH] cxgb4: Remove preprocessor check for CONFIG_CXGB4_DCB
Date: Thu, 29 Jan 2015 15:10:30 -0800 (PST) [thread overview]
Message-ID: <20150129.151030.621632674659139306.davem@davemloft.net> (raw)
In-Reply-To: <1422461991-20684-1-git-send-email-hariprasad@chelsio.com>
From: Hariprasad Shenai <hariprasad@chelsio.com>
Date: Wed, 28 Jan 2015 21:49:51 +0530
> In commit dc9daab226aa ("cxgb4: Added support in debugfs to dump
> sge_qinfo") a preprocessor check for CONFIG_CXGB4_DCB got added, which should
> have been CONFIG_CHELSIO_T4_DCB.
>
> Reported-by: Paul Bolle <pebolle@tiscal.nl>
> Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
That's not all this patch is doing:
> +static inline struct port_info *ethqset2pinfo(struct adapter *adap, int qset)
You need to explain why this function needs to be added in the
commit message.
I can see myself that the build fails without it because you
forgot to add it in the original commit, or someone removed
it meanwhile, but you have to say so in the commit message
so everyone can understand.
prev parent reply other threads:[~2015-01-29 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 16:19 [PATCH] cxgb4: Remove preprocessor check for CONFIG_CXGB4_DCB Hariprasad Shenai
2015-01-29 23:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150129.151030.621632674659139306.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anish@chelsio.com \
--cc=hariprasad@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=praveenm@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).