From: David Miller <davem@davemloft.net>
To: sonic.adi@gmail.com
Cc: peppe.cavallaro@st.com, netdev@vger.kernel.org,
adi-buildroot-devel@lists.sourceforge.net,
sonic.zhang@analog.com
Subject: Re: [PATCH] stmmac: DMA threshold mode or SF mode can be different among multiple device instance
Date: Thu, 29 Jan 2015 15:28:39 -0800 (PST) [thread overview]
Message-ID: <20150129.152839.1317212559062872075.davem@davemloft.net> (raw)
In-Reply-To: <1422521699-14096-1-git-send-email-sonic.adi@gmail.com>
From: Sonic Zhang <sonic.adi@gmail.com>
Date: Thu, 29 Jan 2015 16:54:59 +0800
> /* Try to bump up the dma threshold on this failure */
> - if (unlikely(tc != SF_DMA_MODE) && (tc <= 256)) {
> + if (unlikely(priv->xstats.threshold != SF_DMA_MODE) &&
> + (tc <= 256)) {
This is not indented properly. The second line of the conditional
should start precisely at the first column after the openning
parenthesis of the if() statement.
prev parent reply other threads:[~2015-01-29 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 8:54 [PATCH] stmmac: DMA threshold mode or SF mode can be different among multiple device instance Sonic Zhang
2015-01-29 23:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150129.152839.1317212559062872075.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=sonic.adi@gmail.com \
--cc=sonic.zhang@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).