From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch -mainline] fm10k: drop upper bits of VLAN ID Date: Fri, 30 Jan 2015 13:50:38 +0300 Message-ID: <20150130105038.GL6507@mwanda> References: <20150130084127.GE21357@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kernel-janitors@vger.kernel.org, Linux NICS , e1000-devel@lists.sourceforge.net, Bruce Allan , Jesse Brandeburg , John Ronciak , netdev@vger.kernel.org To: Jeff Kirsher , Alexander Duyck Return-path: Content-Disposition: inline In-Reply-To: <20150130084127.GE21357@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org On Fri, Jan 30, 2015 at 11:41:27AM +0300, Dan Carpenter wrote: > Static checkers complain that the shifts in "(vid << 4) >> 4" perfectly > cancel each other out and the code is a no-op. "vid" is a u16. The > comment says that the intention here is to drop the upper bits so I have > added a cast to "u16" to do that. > > Fixes: 401b5383c6c9 ('fm10k: Add support for configuring PF interface') > Signed-off-by: Dan Carpenter Oh... Rasmus Villemoes already fixed this. regards, dan carpenter ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired