From: Thomas Graf <tgraf@suug.ch>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@vger.kernel.org
Subject: Re: rhashtable: Fix potential crash on destroy in rhashtable_shrink
Date: Sat, 31 Jan 2015 12:15:47 +0000 [thread overview]
Message-ID: <20150131121547.GA27437@casper.infradead.org> (raw)
In-Reply-To: <20150131112209.GA29869@gondor.apana.org.au>
On 01/31/15 at 10:22pm, Herbert Xu wrote:
> That's too late. nft_hash will have freed all the elements
> before rhashtable_destroy gets called.
I see, so this is to accomodate nft_hash which doesn't remove
the elements from the hash but just frees them.
Acked-by: Thomas Graf <tgraf@suug.ch>
next prev parent reply other threads:[~2015-01-31 12:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 9:36 rhashtable: Fix potential crash on destroy in rhashtable_shrink Herbert Xu
2015-01-31 11:16 ` Thomas Graf
2015-01-31 11:22 ` Herbert Xu
2015-01-31 12:15 ` Thomas Graf [this message]
2015-02-02 9:34 ` Ying Xue
2015-02-02 9:48 ` Thomas Graf
2015-02-03 3:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150131121547.GA27437@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).