From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: rocker: Change netdev names to include slot number Date: Mon, 02 Feb 2015 14:16:44 -0800 (PST) Message-ID: <20150202.141644.1997150889832162344.davem@davemloft.net> References: <1422856985-16530-1-git-send-email-dsahern@gmail.com> <54CFEF20.8060300@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: sfeldma@gmail.com, netdev@vger.kernel.org To: dsahern@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:48715 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933530AbbBBWQo (ORCPT ); Mon, 2 Feb 2015 17:16:44 -0500 In-Reply-To: <54CFEF20.8060300@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Mon, 02 Feb 2015 14:41:52 -0700 > On 2/2/15 2:33 PM, Scott Feldman wrote: >> On Sun, Feb 1, 2015 at 10:03 PM, David Ahern >> wrote: >>> Currently, rocker devices are given eth%d names. If you have multiple >>> rocker devices it is difficult to easily correlate eth%d names to a >>> rocker device and port. Change the device name to sw + PCI slot >>> number + p + id (sw%dp%d). This makes the device names easier to >>> correlate. ie., Rather than eth0, ..., eth N (N = number of ports in >>> device) the ports get netdev names like sw5p0, ..., sw5pN. >> >> I think udev is the preferred tool for interface naming, rather than >> hard-coding interface names in the driver. >> > > hmmm... What I am seeing right now is a race as to which devices are > detected first -- rocker or virtio. On half of the boots the virtio > are detected first and named eth0 and eth1. The other half of the > boots virtio devices are detected last and become ethN+1 and ethN+2 > (N=number of rocker ports) -- which makes it a PITA to script > commands. AFAIK udev won't solve that problem. udev has already tackled this problem, it uses platform specific code to determine the physical geographic location of devices on the bus, and uses that to map device names.