From: David Miller <davem@davemloft.net>
To: mleitner@redhat.com
Cc: netdev@vger.kernel.org, harish.patil@qlogic.com, cdupuis@redhat.com
Subject: Re: [PATCH net] qlge: Fix qlge_update_hw_vlan_features to handle if interface is down
Date: Mon, 02 Feb 2015 17:51:35 -0800 (PST) [thread overview]
Message-ID: <20150202.175135.299745251563275368.davem@davemloft.net> (raw)
In-Reply-To: <10e24de024f81e60ab64a6f0bf9647d27eb40be1.1422618157.git.mleitner@redhat.com>
From: Marcelo Ricardo Leitner <mleitner@redhat.com>
Date: Fri, 30 Jan 2015 09:56:01 -0200
> Currently qlge_update_hw_vlan_features() will always first put the
> interface down, then update features and then bring it up again. But it
> is possible to hit this code while the adapter is down and this causes a
> non-paired call to napi_disable(), which will get stuck.
>
> This patch fixes it by skipping these down/up actions if the interface
> is already down.
>
> Fixes: a45adbe8d352 ("qlge: Enhance nested VLAN (Q-in-Q) handling.")
> Cc: Harish Patil <harish.patil@qlogic.com>
> Signed-off-by: Marcelo Ricardo Leitner <mleitner@redhat.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2015-02-03 1:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 11:56 [PATCH net] qlge: Fix qlge_update_hw_vlan_features to handle if interface is down Marcelo Ricardo Leitner
2015-01-30 23:40 ` Harish Patil
2015-02-03 1:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202.175135.299745251563275368.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cdupuis@redhat.com \
--cc=harish.patil@qlogic.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).