From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fam Zheng Subject: Re: [PATCH target] vhost/scsi: vhost_skip_iovec_bytes() can be static Date: Mon, 2 Feb 2015 14:35:55 +0800 Message-ID: <20150202063555.GA7376@ad.nay.redhat.com> References: <201502021411.KBLYtCzS%fengguang.wu@intel.com> <20150202062521.GA18113@snb> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kbuild-all@01.org To: kbuild test robot Return-path: Content-Disposition: inline In-Reply-To: <20150202062521.GA18113@snb> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Mon, 02/02 14:25, kbuild test robot wrote: > drivers/vhost/scsi.c:1081:5: sparse: symbol 'vhost_skip_iovec_bytes' was not declared. Should it be static? > > Signed-off-by: Fengguang Wu > --- > scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c > index d888bd9..8ac003f 100644 > --- a/drivers/vhost/scsi.c > +++ b/drivers/vhost/scsi.c > @@ -1078,7 +1078,7 @@ vhost_scsi_send_bad_target(struct vhost_scsi *vs, > pr_err("Faulted on virtio_scsi_cmd_resp\n"); > } > > -int vhost_skip_iovec_bytes(size_t bytes, int max_niov, > +static int vhost_skip_iovec_bytes(size_t bytes, int max_niov, > struct iovec *iov_in, size_t off_in, > struct iovec **iov_out, size_t *off_out) Probably keep the parameter list lines aligned? Fam