Netdev List
 help / color / mirror / Atom feed
From: "Ignacy Gawędzki" <ignacy.gawedzki@green-communications.fr>
To: netdev@vger.kernel.org
Subject: [PATCH net 0/1] Re: RFC: Fix "tc filter show" for basic filters
Date: Tue, 3 Feb 2015 18:32:34 +0100	[thread overview]
Message-ID: <20150203173234.GA6246@zenon.in.qult.net> (raw)
In-Reply-To: <20150203141059.GA25454@zenon.in.qult.net>

Hi again,

After some playing around, I found that my quick-and-dirty fix didn't actually
do the job.  I eventually traced the problem to come from the fact that
tcf_exts_dump_stats() just assumed that the list of actions in exts->actions
contains at least one element and accessed it using tcf_exts_first_act().
This is clearly not true in the case of filters with no associated action in
particular, as in the case of my "basic" filter.

Simply ensuring that the list is not empty beforehand is enough to fix the
problem, just as is also done above in tcf_exts_dump().

Ignacy Gawędzki (1):
  cls_api.c: Fix dumping of non-existing actions' stats.

 net/sched/cls_api.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

-- 
2.1.0

  reply	other threads:[~2015-02-03 17:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03 14:11 RFC: Fix "tc filter show" for basic filters Ignacy Gawedzki
2015-02-03 17:32 ` Ignacy Gawędzki [this message]
2015-02-03 17:32 ` [PATCH net 1/1] cls_api.c: Fix dumping of non-existing actions' stats Ignacy Gawędzki
2015-02-03 17:39   ` Cong Wang
2015-02-03 17:51     ` Eric Dumazet
2015-02-03 18:05     ` [PATCH net v2] " Ignacy Gawędzki
2015-02-03 18:10       ` Cong Wang
2015-02-05  4:26   ` [PATCH net 1/1] " David Miller
2015-02-25  0:20     ` Cong Wang
2015-02-25  2:15       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150203173234.GA6246@zenon.in.qult.net \
    --to=ignacy.gawedzki@green-communications.fr \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox