From: David Miller <davem@davemloft.net>
To: gang.chen@sunrus.com.cn
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: usb: sr9700: Use 'SR_' prefix for the common register macros
Date: Wed, 04 Feb 2015 13:53:27 -0800 (PST) [thread overview]
Message-ID: <20150204.135327.2016424933291153633.davem@davemloft.net> (raw)
In-Reply-To: <54CFE578.7030207@sunrus.com.cn>
From: Chen Gang S <gang.chen@sunrus.com.cn>
Date: Tue, 03 Feb 2015 05:00:40 +0800
> The commone register macors (e.g. RSR) is too commont to drivers, it may
> be conflict with the architectures (e.g. xtensa, sh).
>
> The related warnings (with allmodconfig under xtensa):
>
> CC [M] drivers/net/usb/sr9700.o
> In file included from drivers/net/usb/sr9700.c:24:0:
> drivers/net/usb/sr9700.h:65:0: warning: "RSR" redefined
> #define RSR 0x06
> ^
> In file included from ./arch/xtensa/include/asm/bitops.h:22:0,
> from include/linux/bitops.h:36,
> from include/linux/kernel.h:10,
> from include/linux/list.h:8,
> from include/linux/module.h:9,
> from drivers/net/usb/sr9700.c:13:
> ./arch/xtensa/include/asm/processor.h:190:0: note: this is the location of the previous definition
> #define RSR(v,sr) __asm__ __volatile__ ("rsr %0,"__stringify(sr) : "=a"(v));
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2015-02-04 21:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 21:00 [PATCH] net: usb: sr9700: Use 'SR_' prefix for the common register macros Chen Gang S
2015-02-04 21:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150204.135327.2016424933291153633.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gang.chen@sunrus.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).