From: Sabrina Dubroca <sd@queasysnail.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net] ip6_gre: fix endianness errors in ip6gre_err
Date: Thu, 5 Feb 2015 00:38:30 +0100 [thread overview]
Message-ID: <20150204233830.GA10793@kria> (raw)
In-Reply-To: <1423065012.907.138.camel@edumazet-glaptop2.roam.corp.google.com>
2015-02-04, 07:50:12 -0800, Eric Dumazet wrote:
> On Wed, 2015-02-04 at 07:44 -0800, Eric Dumazet wrote:
> > On Wed, 2015-02-04 at 15:25 +0100, Sabrina Dubroca wrote:
> > > info is in network byte order, change it back to host byte order
> > > before use. In particular, the current code sets the MTU of the tunnel
> > > to a wrong (too big) value.
> > >
> > > Fixes: c12b395a4664 ("gre: Support GRE over IPv6")
> > > Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
> > > ---
> >
> > Acked-by: Eric Dumazet <edumazet@google.com>
> >
>
>
> BTW, "fl6.flowi6_proto = skb->protocol; " in ip6gre_xmit_other()
> looks suspicious...
Yes, I know that sparse complains about it. I don't know how to
handle that for now. ntohs would silence the sparse warning, but we
would still have u8 vs u16. I'll need to have a closer look.
--
Sabrina
next prev parent reply other threads:[~2015-02-04 23:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 14:25 [PATCH net] ip6_gre: fix endianness errors in ip6gre_err Sabrina Dubroca
2015-02-04 15:44 ` Eric Dumazet
2015-02-04 15:50 ` Eric Dumazet
2015-02-04 23:38 ` Sabrina Dubroca [this message]
2015-02-05 8:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150204233830.GA10793@kria \
--to=sd@queasysnail.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox