From: Thomas Graf <tgraf@suug.ch>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH 3/4] netlink: Use rhashtable walk iterator
Date: Thu, 5 Feb 2015 00:25:17 +0000 [thread overview]
Message-ID: <20150205002517.GA1685@casper.infradead.org> (raw)
In-Reply-To: <E1YIkA0-00063W-Hi@gondolin.me.apana.org.au>
On 02/04/15 at 07:33am, Herbert Xu wrote:
> This patch gets rid of the manual rhashtable walk in netlink
> which touches rhashtable internals that should not be exposed.
> It does so by using the rhashtable iterator primitives.
>
> In fact the existing code was very buggy. Some sockets weren't
> shown at all while others were shown more than once.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
I tested these patches. Only thing I found are these sparse
warnings:
net/netlink/af_netlink.c:2893:12: warning: context imbalance in 'netlink_walk_start' - different lock contexts for basic block
net/netlink/af_netlink.c:2907:13: warning: context imbalance in 'netlink_walk_stop' - unexpected unlock
next prev parent reply other threads:[~2015-02-05 0:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 10:21 rhashtable: Move hash_rnd into bucket_table Herbert Xu
2015-01-31 10:23 ` [RFC] rhashtable: rhashtable_rehash Herbert Xu
2015-02-02 11:16 ` Thomas Graf
2015-03-09 10:13 ` Herbert Xu
2015-01-31 11:17 ` rhashtable: Move hash_rnd into bucket_table Thomas Graf
2015-02-03 3:19 ` David Miller
2015-02-03 3:26 ` David Miller
2015-02-03 20:17 ` Herbert Xu
2015-02-03 20:32 ` [PATCH 0/4] rhashtable: Add iterators and use them Herbert Xu
2015-02-03 20:33 ` [PATCH 1/4] rhashtable: Fix potential crash on destroy in rhashtable_shrink Herbert Xu
2015-02-03 20:33 ` [PATCH 2/4] rhashtable: Introduce rhashtable_walk_* Herbert Xu
2015-02-03 20:33 ` [PATCH 3/4] netlink: Use rhashtable walk iterator Herbert Xu
2015-02-05 0:25 ` Thomas Graf [this message]
2015-02-03 20:33 ` [PATCH 4/4] netfilter: " Herbert Xu
2015-02-05 4:35 ` [PATCH 0/4] rhashtable: Add iterators and use them David Miller
2015-03-09 9:58 ` rhashtable: Move hash_rnd into bucket_table Herbert Xu
2015-03-09 16:26 ` Daniel Borkmann
2015-03-09 22:21 ` Herbert Xu
2015-03-09 19:51 ` David Miller
2015-03-09 19:55 ` David Miller
2015-03-09 22:26 ` [PATCH 0/2] rhashtable: Arbitrary rehashing Herbert Xu
2015-03-09 22:27 ` [PATCH 1/2] rhashtable: Move hash_rnd into bucket_table Herbert Xu
2015-03-10 17:20 ` Thomas Graf
2015-03-10 21:48 ` Herbert Xu
2015-03-09 22:27 ` [PATCH 2/2] rhashtable: Add arbitrary rehash function Herbert Xu
2015-03-10 18:17 ` Thomas Graf
2015-03-10 22:01 ` Herbert Xu
2015-03-10 22:43 ` [PATCH v2] " Herbert Xu
2015-03-11 20:37 ` David Miller
2015-03-11 21:07 ` Herbert Xu
2015-03-09 22:32 ` [PATCH 0/2] rhashtable: Arbitrary rehashing Josh Triplett
2015-03-10 18:20 ` Thomas Graf
2015-03-12 16:46 ` Thomas Graf
2015-03-13 1:54 ` Herbert Xu
2015-03-13 3:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205002517.GA1685@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).