From: Thomas Graf <tgraf@noironetworks.com>
To: Andy Zhou <azhou@nicira.com>
Cc: dev@openvswitch.com, netdev@vger.kernel.org
Subject: Re: [ovs-dev] [RFC: add openvswitch actions using BPF 2/2] openvswitch: implements the BPF_PROG action in datapath
Date: Thu, 5 Feb 2015 16:07:33 +0100 [thread overview]
Message-ID: <20150205150733.GG5546@pox.localdomain> (raw)
In-Reply-To: <1423090122-19807-3-git-send-email-azhou@nicira.com>
On 02/04/15 at 02:48pm, Andy Zhou wrote:
> BPF_PROG action allows an action to be implemented in eBPF language and
> downloaded by the userspace at runtime.
>
> Signed-off-by: Andy Zhou <azhou@nicira.com>
Thanks a lot for putting this together Andy and Joe and everybody else
who was involved. This is much further than what I expected as a first
step.
One slight open from my side is the avoidance of versioning help of
helpers. We want to avoid v2, v3, ... helpers if the need should arise
to extend an existing helper.
I think it should be doable with BPF to have the verifier accept if
a helper is called with less args than expected, to initialize those
to 0. This would allow for helpers to support additional arguments.
I think this needs to be documented and expectations should be clear.
Other than that I'm very very happy with where this is going.
It seems very doable to also allow for a BPF prog to be registered
upon flow table miss.
next prev parent reply other threads:[~2015-02-05 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 22:48 [RFC: add openvswitch actions using BPF 0/2] Andy Zhou
[not found] ` <1423090122-19807-1-git-send-email-azhou-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
2015-02-04 22:48 ` [RFC: add openvswitch actions using BPF 1/2] BPF: add a new BPF program type BPF_PROG_TYPE_OPENVSWITCH Andy Zhou
2015-02-05 14:48 ` [ovs-dev] " Thomas Graf
2015-02-05 19:47 ` Andy Zhou
2015-02-04 22:48 ` [RFC: add openvswitch actions using BPF 2/2] openvswitch: implements the BPF_PROG action in datapath Andy Zhou
2015-02-05 15:07 ` Thomas Graf [this message]
2015-02-05 19:34 ` [ovs-dev] " Andy Zhou
-- strict thread matches above, loose matches on Subject: below --
2015-02-05 20:49 Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205150733.GG5546@pox.localdomain \
--to=tgraf@noironetworks.com \
--cc=azhou@nicira.com \
--cc=dev@openvswitch.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).