Re: [PATCH] flowcache: Fix kernel panic in flow_cache_flush_task

[Miroslav Urbanek <mu@miroslavurbanek.com>]

Thanks for the tip. It's my first kernel patch, so I wanted to make
sure it won't get lost :-)

Anyway, I also looked into the function flow_cache_fini. Isn't it
necessary to flush/cancel scheduled works here? Something like:

flush_work(&net->xfrm.flow_cache_flush_work);
flush_work(&net->xfrm.flow_cache_gc_work);

I'm not sure if it is a bug or not. Could it happen that there is a
scheduled work while the kernel calls flow_cache_fini?

I originally suspected this was the real bug we hit, but we don't use
net namespaces, so our kernels never call flow_cache_fini.

> 
> Nice catch !
> 
> Ok, but you do not need to cc so many people/lists
> 
> netdev is fine, and we usually CC patch author, just in case.
> 
> Acked-by: Eric Dumazet <edumazet@google.com>
>