* [PATCH] at86rf230: assign wait_for_completion_timeout to appropriately typed var
@ 2015-02-08 8:55 Nicholas Mc Guire
2015-02-08 9:34 ` Alexander Aring
0 siblings, 1 reply; 4+ messages in thread
From: Nicholas Mc Guire @ 2015-02-08 8:55 UTC (permalink / raw)
To: Alexander Aring; +Cc: linux-wpan, netdev, linux-kernel, Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int.
As rc is used here only for wait_for_completion_timeout the type is simply
changed to unsigned long.
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
Patch was only compile tested with x86_64_defconfig + CONFIG_IEEE802154=m,
CONFIG_MAC802154=m CONFIG_SPI=m, CONFIG_IEEE802154_AT86RF230=m
Patch is against 3.19.0-rc7 (localversion-next is -next-20150204)
drivers/net/ieee802154/at86rf230.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index 7b051ea..cbfc8c5 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -689,7 +689,7 @@ at86rf230_sync_state_change_complete(void *context)
static int
at86rf230_sync_state_change(struct at86rf230_local *lp, unsigned int state)
{
- int rc;
+ unsigned long rc;
at86rf230_async_state_change(lp, &lp->state, state,
at86rf230_sync_state_change_complete,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] at86rf230: assign wait_for_completion_timeout to appropriately typed var
2015-02-08 8:55 [PATCH] at86rf230: assign wait_for_completion_timeout to appropriately typed var Nicholas Mc Guire
@ 2015-02-08 9:34 ` Alexander Aring
2015-02-14 21:34 ` Alexander Aring
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Aring @ 2015-02-08 9:34 UTC (permalink / raw)
To: Nicholas Mc Guire; +Cc: linux-wpan, netdev, linux-kernel, marcel
On Sun, Feb 08, 2015 at 03:55:00AM -0500, Nicholas Mc Guire wrote:
> return type of wait_for_completion_timeout is unsigned long not int.
> As rc is used here only for wait_for_completion_timeout the type is simply
> changed to unsigned long.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Acked-by: Alexander Aring <alex.aring@gmail.com>
Marcel, can you please queue this for bluetooth-next. Should be able to
apply against bluetooth-next. Thanks.
- Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] at86rf230: assign wait_for_completion_timeout to appropriately typed var
2015-02-08 9:34 ` Alexander Aring
@ 2015-02-14 21:34 ` Alexander Aring
2015-02-14 21:48 ` Marcel Holtmann
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Aring @ 2015-02-14 21:34 UTC (permalink / raw)
To: Nicholas Mc Guire; +Cc: linux-wpan, netdev, linux-kernel, marcel
On Sun, Feb 08, 2015 at 10:34:34AM +0100, Alexander Aring wrote:
> On Sun, Feb 08, 2015 at 03:55:00AM -0500, Nicholas Mc Guire wrote:
> > return type of wait_for_completion_timeout is unsigned long not int.
> > As rc is used here only for wait_for_completion_timeout the type is simply
> > changed to unsigned long.
> >
> > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
>
> Acked-by: Alexander Aring <alex.aring@gmail.com>
>
> Marcel, can you please queue this for bluetooth-next. Should be able to
> apply against bluetooth-next. Thanks.
>
Marcel, ping.
- Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] at86rf230: assign wait_for_completion_timeout to appropriately typed var
2015-02-14 21:34 ` Alexander Aring
@ 2015-02-14 21:48 ` Marcel Holtmann
0 siblings, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2015-02-14 21:48 UTC (permalink / raw)
To: Alexander Aring; +Cc: Nicholas Mc Guire, linux-wpan, netdev, linux-kernel
Hi Alex,
>>> return type of wait_for_completion_timeout is unsigned long not int.
>>> As rc is used here only for wait_for_completion_timeout the type is simply
>>> changed to unsigned long.
>>>
>>> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
>>
>> Acked-by: Alexander Aring <alex.aring@gmail.com>
>>
>> Marcel, can you please queue this for bluetooth-next. Should be able to
>> apply against bluetooth-next. Thanks.
>>
>
> Marcel, ping.
my apologizes, but this one never made it to my archive. Please resend and I apply it.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-14 21:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-08 8:55 [PATCH] at86rf230: assign wait_for_completion_timeout to appropriately typed var Nicholas Mc Guire
2015-02-08 9:34 ` Alexander Aring
2015-02-14 21:34 ` Alexander Aring
2015-02-14 21:48 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).