Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: aleksander@aleksander.es
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, j.dumon@option.com
Subject: Re: [PATCH] hso: fix rx parsing logic when skb allocation fails
Date: Fri, 13 Feb 2015 07:17:29 -0800 (PST)	[thread overview]
Message-ID: <20150213.071729.1526535214803147119.davem@davemloft.net> (raw)
In-Reply-To: <1423835462-3454-1-git-send-email-aleksander@aleksander.es>

From: Aleksander Morgado <aleksander@aleksander.es>
Date: Fri, 13 Feb 2015 14:51:02 +0100

> If skb allocation fails once the IP header has been received, the rx state is
> being set to WAIT_SYNC. The logic, though, shouldn't directly return, as the
> buffer may contain a full packet, and therefore the WAIT_SYNC state needs to be
> processed (resetting state to WAIT_IP, clearing rx_buf_size and re-initializing
> rx_buf_missing).
> 
> So, just let the while loop continue so that in the next iteration the WAIT_SYNC
> state cleanly stops the loop. The WAIT_SYNC processing will be done just after
> that, only if the end of packet is flagged.
> 
> Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>

Applied, thanks.

      reply	other threads:[~2015-02-13 15:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13 13:51 [PATCH] hso: fix rx parsing logic when skb allocation fails Aleksander Morgado
2015-02-13 15:17 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150213.071729.1526535214803147119.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=aleksander@aleksander.es \
    --cc=j.dumon@option.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox