From: Thomas Graf <tgraf@suug.ch>
To: Joe Stringer <joestringer@nicira.com>
Cc: netdev@vger.kernel.org, Justin Pettit <jpettit@nicira.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
dev@openvswitch.org
Subject: Re: [RFC net-next 3/4] openvswitch: Add conntrack action.
Date: Sat, 14 Feb 2015 19:56:07 +0000 [thread overview]
Message-ID: <20150214195607.GA30752@casper.infradead.org> (raw)
In-Reply-To: <1423901633-53789-4-git-send-email-joestringer@nicira.com>
On 02/14/15 at 12:13am, Joe Stringer wrote:
[..]
> +static bool skb_has_valid_nfct(const struct net *net, u16 zone,
> + const struct sk_buff *skb)
> +{
> + enum ip_conntrack_info ctinfo;
> + struct nf_conn *ct = nf_ct_get(skb, &ctinfo);
> +
> + if (!ct)
> + return false;
> + if (!net_eq(net, ct->ct_net))
> + return false;
I'm surprised that this is needed. Shouldn't we call skb_scrub_packet()
between namespaces and invalidate the ct associated with the skb.
next prev parent reply other threads:[~2015-02-14 19:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-14 8:13 [RFC net-next 0/4] OVS conntrack support Joe Stringer
2015-02-14 8:13 ` [RFC net-next 1/4] openvswitch: Serialize acts with original netlink len Joe Stringer
2015-02-14 8:13 ` [RFC net-next 2/4] openvswitch: Move MASKED* macros to datapath.h Joe Stringer
2015-02-14 8:13 ` [RFC net-next 3/4] openvswitch: Add conntrack action Joe Stringer
2015-02-14 8:20 ` Joe Stringer
2015-02-14 19:56 ` Thomas Graf [this message]
[not found] ` <20150214195607.GA30752-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2015-02-15 4:47 ` Joe Stringer
2015-02-15 15:08 ` Nicolas Dichtel
[not found] ` <54E0B67A.1030000-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-02-15 19:06 ` Joe Stringer
2015-02-15 19:13 ` Thomas Graf
2015-02-15 19:51 ` Nicolas Dichtel
2015-02-14 8:13 ` [RFC net-next 4/4] openvswitch: Allow matching on conntrack mark Joe Stringer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150214195607.GA30752@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=dev@openvswitch.org \
--cc=joestringer@nicira.com \
--cc=jpettit@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).