From: "Ignacy Gawędzki" <ignacy.gawedzki@green-communications.fr>
To: Cong Wang <cwang@twopensource.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] ematch: Fix auto-loading of ematch modules.
Date: Mon, 16 Feb 2015 19:50:11 +0100 [thread overview]
Message-ID: <20150216185011.GA29935@zenon.in.qult.net> (raw)
In-Reply-To: <CAHA+R7McGmFtXpiEJkOV2Jjgy29kzpX7tTeprS7S0pY2m9mJBw@mail.gmail.com>
On Mon, Feb 16, 2015 at 10:36:06AM -0800, thus spake Cong Wang:
> On Mon, Feb 16, 2015 at 10:13 AM, Ignacy Gawędzki
> <ignacy.gawedzki@green-communications.fr> wrote:
> > In tcf_em_validate(), when calling tcf_em_lookup(), don't put the resulting
> > pointer directly into em->ops, if the function is to possibly return -EAGAIN
> > after module auto-loading. Otherwise, module_put() will be called by
> > tcf_em_tree_destroy() on em->ops->owner, while it has already been called by
> > tcf_em_validate() before return.
> >
>
> Or simply reset em->ops to NULL after module_put()?
Yeah, why not. I just got my inspiration from what's done in cls_api.c and
act_api.c. What do you think, should the same simplification be applied to
cls_api.c?
--
Ignacy Gawędzki
R&D Engineer
Green Communications
next prev parent reply other threads:[~2015-02-16 18:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 10:59 Attempt to auto-load em_cmp.ko results in negative module refcnt Ignacy Gawedzki
2015-02-16 15:03 ` Ignacy Gawedzki
2015-02-16 18:13 ` [PATCH net] ematch: Fix auto-loading of ematch modules Ignacy Gawędzki
2015-02-16 18:36 ` Cong Wang
2015-02-16 18:50 ` Ignacy Gawędzki [this message]
2015-02-17 18:00 ` Cong Wang
2015-02-17 19:15 ` [PATCH net v2] " Ignacy Gawędzki
2015-02-18 5:17 ` Cong Wang
2015-02-20 20:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150216185011.GA29935@zenon.in.qult.net \
--to=ignacy.gawedzki@green-communications.fr \
--cc=cwang@twopensource.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox