From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Balazs Scheidler <bazsi@balabit.hu>,
KOVACS Krisztian <hidden@balabit.hu>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
netfilter-devel@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] netfilter: xt_socket: fix a stack corruption bug
Date: Thu, 19 Feb 2015 00:45:42 +0100 [thread overview]
Message-ID: <20150218234542.GA21773@salvia> (raw)
In-Reply-To: <1424055825.4942.50.camel@edumazet-glaptop2.roam.corp.google.com>
On Sun, Feb 15, 2015 at 07:03:45PM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> As soon as extract_icmp6_fields() returns, its local storage (automatic
> variables) is deallocated and can be overwritten.
>
> Lets add an additional parameter to make sure storage is valid long
> enough.
>
> While we are at it, adds some const qualifiers.
Applied, thanks Eric.
prev parent reply other threads:[~2015-02-18 23:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 3:03 [PATCH net] netfilter: xt_socket: fix a stack corruption bug Eric Dumazet
2015-02-18 23:45 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150218234542.GA21773@salvia \
--to=pablo@netfilter.org \
--cc=bazsi@balabit.hu \
--cc=eric.dumazet@gmail.com \
--cc=hidden@balabit.hu \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).