From: David Miller <davem@davemloft.net>
To: rvatsavayi@caviumnetworks.com
Cc: netdev@vger.kernel.org, derek.chickles@caviumnetworks.com,
satananda.burla@caviumnetworks.com,
felix.manlunas@caviumnetworks.com,
raghu.vatsavayi@caviumnetworks.com
Subject: Re: [PATCH net-next v5] Add support of Cavium Liquidio ethernet adapters
Date: Thu, 19 Feb 2015 14:36:10 -0500 (EST) [thread overview]
Message-ID: <20150219.143610.1038570471548445608.davem@davemloft.net> (raw)
In-Reply-To: <1423704042-4026-1-git-send-email-rvatsavayi@caviumnetworks.com>
From: Raghu Vatsavayi <rvatsavayi@caviumnetworks.com>
Date: Wed, 11 Feb 2015 17:20:42 -0800
> + uint32_t val;
uint32_t, uint64_t, etc. are userspace types, and inside the kernel
one should canonically use u32, u64, etc.
Please update your entire driver wrt. this issue.
> + pci_unmap_single(lio->oct_dev->pci_dev, finfo->dptr, skb->len,
> + PCI_DMA_TODEVICE);
Please use the dma_*() variants of the DMA interfaces for which you
will pass in a reference to the struct device embedded in the pci_dev.
This will allow you to later make use of various generic facilities
we will build for DMA mapping SKBs in the networking, allocating
networknig page frags, etc.
And even more importantly, the pci_*() variants are slowly being
phased out and deprecated.
next prev parent reply other threads:[~2015-02-19 19:36 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 3:19 [PATCH v2] Add support of Cavium Liquidio ethernet adapters Raghu Vatsavayi
2014-11-24 20:52 ` Daniel Borkmann
2014-11-24 21:01 ` Florian Fainelli
2014-11-24 21:08 ` David Miller
2014-12-01 19:57 ` Vatsavayi, Raghu
2014-12-19 3:25 ` [PATCH net-next v3] " Raghu Vatsavayi
2014-12-19 6:59 ` Stephen Hemminger
2014-12-19 17:54 ` Chickles, Derek
2014-12-19 7:01 ` Stephen Hemminger
2014-12-19 7:03 ` Stephen Hemminger
2014-12-19 7:05 ` Stephen Hemminger
2014-12-19 7:07 ` Stephen Hemminger
2014-12-19 7:11 ` Stephen Hemminger
2014-12-19 7:14 ` Stephen Hemminger
2014-12-19 7:21 ` Stephen Hemminger
2014-12-19 7:23 ` Stephen Hemminger
2014-12-19 7:26 ` Stephen Hemminger
2014-12-19 7:28 ` Stephen Hemminger
2014-12-19 18:39 ` Chickles, Derek
2014-12-19 20:53 ` Stephen Hemminger
2014-12-19 20:44 ` Lino Sanfilippo
2014-12-19 20:54 ` Stephen Hemminger
2014-12-19 21:00 ` Lino Sanfilippo
2014-12-19 21:07 ` Lino Sanfilippo
2014-12-19 21:14 ` Lino Sanfilippo
2014-12-19 21:48 ` Lino Sanfilippo
2014-12-19 22:39 ` Chickles, Derek
2014-12-19 22:04 ` Lino Sanfilippo
2014-12-19 22:20 ` Chickles, Derek
2014-12-19 22:24 ` Lino Sanfilippo
2014-12-19 22:53 ` Chickles, Derek
2014-12-19 22:51 ` Lino Sanfilippo
2014-12-20 0:47 ` Chickles, Derek
2015-01-31 2:29 ` [PATCH net-next v4] " Raghu Vatsavayi
2015-02-03 3:00 ` David Miller
2015-02-06 20:28 ` Chickles, Derek
2015-02-12 1:20 ` [PATCH net-next v5] " Raghu Vatsavayi
2015-02-19 19:36 ` David Miller [this message]
2015-02-19 20:44 ` Chickles, Derek
2015-02-19 21:21 ` David Miller
2015-02-19 21:28 ` Chickles, Derek
2015-04-08 19:08 ` [PATCH net-next v6] " Raghu Vatsavayi
2015-04-09 0:46 ` Joe Perches
2015-04-25 0:34 ` [PATCH net-next v7] " Raghu Vatsavayi
2015-04-26 20:04 ` David Miller
2015-04-27 16:26 ` Chickles, Derek
2015-04-27 16:27 ` David Miller
2015-04-27 17:04 ` Chickles, Derek
2015-04-27 17:22 ` David Miller
2015-06-10 1:15 ` [PATCH net-next v8] " Raghu Vatsavayi
2015-06-11 5:45 ` David Miller
2014-12-20 0:33 ` [PATCH net-next v3] " Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219.143610.1038570471548445608.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=derek.chickles@caviumnetworks.com \
--cc=felix.manlunas@caviumnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@caviumnetworks.com \
--cc=rvatsavayi@caviumnetworks.com \
--cc=satananda.burla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).