From: David Miller <davem@davemloft.net>
To: xerofoify@gmail.com
Cc: john.fastabend@gmail.com, standby24x7@gmail.com,
xiyou.wangcong@gmail.com, rdunlap@infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Possible Bug in gnet_start_copy_compat for the file,gen_stats.c
Date: Thu, 19 Feb 2015 15:34:56 -0500 (EST) [thread overview]
Message-ID: <20150219.153456.2128213121930417861.davem@davemloft.net> (raw)
In-Reply-To: <54DD626C.80505@gmail.com>
From: nick <xerofoify@gmail.com>
Date: Thu, 12 Feb 2015 21:33:16 -0500
> I am wondering after running sparse on the latest mainline tree why
> we are not unlocking the spinlock_bh,lock when calling the function,
> gnet_stats_start_copy_compat at the end of this function's
> body. Unless someone can explain to me why there is a very good
> reason for not unlocking the spinlock_bh,lock at the end of this
> function I will send in a patch fixing this. I am assuming this is a
> bug due to us infinitely looping in the spinlock_bh and deadlocking
> unless we exit this lock external to the call to the
> function,gnet_start_copy_compat.
This function is used to start a dump, and the caller needs the lock
to be held during the dump operation.
The lock is released by the caller by invoking gnet_stats_finish_copy().
prev parent reply other threads:[~2015-02-19 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <54DD626C.80505@gmail.com>
2015-02-13 3:01 ` Possible Bug in gnet_start_copy_compat for the file,gen_stats.c Cong Wang
2015-02-19 20:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219.153456.2128213121930417861.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=standby24x7@gmail.com \
--cc=xerofoify@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox