From: David Miller <davem@davemloft.net>
To: pallas@meraki.com
Cc: khalasa@piap.pl, netdev@vger.kernel.org
Subject: Re: [PATCH] ethernet/ixp4xx: prevent allmulti from clobbering promisc
Date: Fri, 20 Feb 2015 15:49:27 -0500 (EST) [thread overview]
Message-ID: <20150220.154927.313372314025203773.davem@davemloft.net> (raw)
In-Reply-To: <1424249425-2438-1-git-send-email-pallas@meraki.com>
From: Derrick Pallas <pallas@meraki.com>
Date: Wed, 18 Feb 2015 00:50:25 -0800
> If both promisc and allmulti are set, promisc should trump allmulti and
> disable the MAC filter; otherwise, the interface is not really promisc.
>
> Previously, this code checked IFF_ALLMULTI prior to and without regard for
> IFF_PROMISC; if both were set, only multicast and direct unicast traffic
> would make it through the filter.
>
> Signed-off-by: Derrick Pallas <pallas@meraki.com>
Applied, thanks.
prev parent reply other threads:[~2015-02-20 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 8:50 [PATCH] ethernet/ixp4xx: prevent allmulti from clobbering promisc Derrick Pallas
2015-02-20 20:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220.154927.313372314025203773.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=khalasa@piap.pl \
--cc=netdev@vger.kernel.org \
--cc=pallas@meraki.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox