From: David Miller <davem@davemloft.net>
To: maheshb@google.com
Cc: j.vosburgh@gmail.com, andy@greyhouse.net, vfalico@gmail.com,
nikolay@redhat.com, maze@google.com, netdev@vger.kernel.org,
edumazet@google.com
Subject: Re: [PATCH next v6 2/5] bonding: Implement port churn-machine (AD standard 43.4.17).
Date: Fri, 20 Feb 2015 17:33:45 -0500 (EST) [thread overview]
Message-ID: <20150220.173345.1387126164943361978.davem@davemloft.net> (raw)
In-Reply-To: <1424328619-14205-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Wed, 18 Feb 2015 22:50:19 -0800
> @@ -1131,6 +1137,44 @@ static void ad_rx_machine(struct lacpdu *lacpdu, struct port *port)
> }
> }
>
> +/* ad_churn_machine - handle port churn's state machine
> + * @port: the port we're looking at
> + *
> + */
Please don't invent new styles for the function comments, do it like it is
done in the rest of this file, for example, the very next funtion does:
> /**
> * ad_tx_machine - handle a port's tx state machine
> * @port: the port we're looking at
> + static const char *const churn_description[] =
> + { "monitoring",
> + "churned",
> + "none",
> + "unknown"
> + };
> + int max_size = sizeof(churn_description) / sizeof(churn_description[0]);
Please format this as:
> + static const char *const churn_description[] = {
> + "monitoring",
> + "churned",
> + "none",
> + "unknown"
> + };
prev parent reply other threads:[~2015-02-20 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 6:50 [PATCH next v6 2/5] bonding: Implement port churn-machine (AD standard 43.4.17) Mahesh Bandewar
2015-02-20 22:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220.173345.1387126164943361978.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=maheshb@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox