From: David Miller <davem@davemloft.net>
To: eyal.birger@gmail.com
Cc: netdev@vger.kernel.org, edumazet@google.com, shmulik.ladkani@gmail.com
Subject: Re: [PATCH net-next v2 2/3] net: use skb->priority for overloading skb->dropcount and skb->reserved_tailroom instead of skb->mark
Date: Sun, 22 Feb 2015 15:47:33 -0500 (EST) [thread overview]
Message-ID: <20150222.154733.112061471461322123.davem@davemloft.net> (raw)
In-Reply-To: <CAHsH6Gv709dahHUGqXkb8CYxn+s0-4+1DGksoNfAgMksZYrt9w@mail.gmail.com>
From: Eyal Birger <eyal.birger@gmail.com>
Date: Fri, 20 Feb 2015 13:32:48 +0200
> However, It seems the skb is cloned prior to setting dropcount and
> other skb header fields before it is enqueued in packet_rcv(). Would
> that not prevent interference with the transmit path?
You're right, that should take care of all cases.
Please resubmit this series, perhaps adding some commit
log text explaining this for the next person who reads
these changes.
next prev parent reply other threads:[~2015-02-22 20:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 4:32 [PATCH net-next v2 0/3] net: Introducing socket mark receive socket option Eyal Birger
2015-02-12 4:32 ` [PATCH net-next v2 1/3] net: Rename sock_recv_ts_and_drops() to sock_cmsg_recv() Eyal Birger
2015-02-12 4:32 ` [PATCH net-next v2 2/3] net: use skb->priority for overloading skb->dropcount and skb->reserved_tailroom instead of skb->mark Eyal Birger
2015-02-19 20:05 ` David Miller
2015-02-20 11:32 ` Eyal Birger
2015-02-22 20:47 ` David Miller [this message]
2015-02-12 4:32 ` [PATCH net-next v2 3/3] net: Introducing socket mark receive socket option Eyal Birger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150222.154733.112061471461322123.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eyal.birger@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox