From: Wei Liu <wei.liu2@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: <netdev@vger.kernel.org>, <xen-devel@lists.xenproject.org>,
Ian Campbell <ian.campbell@citrix.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCHv1 net] xen-netback: release pending index before pushing Tx responses
Date: Tue, 24 Feb 2015 12:03:24 +0000 [thread overview]
Message-ID: <20150224120324.GH20083@zion.uk.xensource.com> (raw)
In-Reply-To: <1424776679-7509-1-git-send-email-david.vrabel@citrix.com>
On Tue, Feb 24, 2015 at 11:17:59AM +0000, David Vrabel wrote:
> If the pending indexes are released /after/ pushing the Tx response
> then a stale pending index may be used if a new Tx request is
> immediately pushed by the frontend. The may cause various WARNINGs or
> BUGs if the stale pending index is actually still in use.
>
> Fix this by releasing the pending index before pushing the Tx
> response.
>
> The full barrier for the pending ring update is not required since the
> the Tx response push already has a suitable write barrier.
>
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
next prev parent reply other threads:[~2015-02-24 12:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 11:17 [PATCHv1 net] xen-netback: release pending index before pushing Tx responses David Vrabel
2015-02-24 12:03 ` Wei Liu [this message]
2015-02-24 21:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224120324.GH20083@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox