* [patch v2] sunrpc: integer underflow in rsc_parse() [not found] <20150223211607.GB28635@fieldses.org> @ 2015-02-24 15:34 ` Dan Carpenter 2015-02-25 3:54 ` Simo Sorce 0 siblings, 1 reply; 3+ messages in thread From: Dan Carpenter @ 2015-02-24 15:34 UTC (permalink / raw) To: J. Bruce Fields Cc: Trond Myklebust, Anna Schumaker, David S. Miller, Jeff Layton, Kinglong Mee, linux-nfs, netdev, Eric W. Biederman, Andrew Morton, Andy Lutomirski, Wang YanQing, linux-kernel, kernel-janitors If we call groups_alloc() with invalid values then it's might lead to memory corruption. For example, with a negative value then we might not allocate enough for sizeof(struct group_info). Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- v2: In v1, I changed groups_alloc(). The other places which call groups_alloc() check the value before calling. Eric wanted that, either have all the callers check, or all the callers rely on groups_alloc(). In the end, Bruce Fields said adding the check here was probably reasonable. diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c index 224a82f..1095be9 100644 --- a/net/sunrpc/auth_gss/svcauth_gss.c +++ b/net/sunrpc/auth_gss/svcauth_gss.c @@ -463,6 +463,8 @@ static int rsc_parse(struct cache_detail *cd, /* number of additional gid's */ if (get_int(&mesg, &N)) goto out; + if (N < 0 || N > NGROUPS_MAX) + goto out; status = -ENOMEM; rsci.cred.cr_group_info = groups_alloc(N); if (rsci.cred.cr_group_info == NULL) ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch v2] sunrpc: integer underflow in rsc_parse() 2015-02-24 15:34 ` [patch v2] sunrpc: integer underflow in rsc_parse() Dan Carpenter @ 2015-02-25 3:54 ` Simo Sorce 2015-02-26 20:40 ` J. Bruce Fields 0 siblings, 1 reply; 3+ messages in thread From: Simo Sorce @ 2015-02-25 3:54 UTC (permalink / raw) To: Dan Carpenter Cc: J. Bruce Fields, Trond Myklebust, Anna Schumaker, David S. Miller, Jeff Layton, Kinglong Mee, linux-nfs, netdev, Eric W. Biederman, Andrew Morton, Andy Lutomirski, Wang YanQing, linux-kernel, kernel-janitors On Tue, 2015-02-24 at 18:34 +0300, Dan Carpenter wrote: > If we call groups_alloc() with invalid values then it's might lead to > memory corruption. For example, with a negative value then we might not > allocate enough for sizeof(struct group_info). > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > v2: In v1, I changed groups_alloc(). The other places which call > groups_alloc() check the value before calling. Eric wanted that, either > have all the callers check, or all the callers rely on groups_alloc(). > In the end, Bruce Fields said adding the check here was probably > reasonable. > > diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c > index 224a82f..1095be9 100644 > --- a/net/sunrpc/auth_gss/svcauth_gss.c > +++ b/net/sunrpc/auth_gss/svcauth_gss.c > @@ -463,6 +463,8 @@ static int rsc_parse(struct cache_detail *cd, > /* number of additional gid's */ > if (get_int(&mesg, &N)) > goto out; > + if (N < 0 || N > NGROUPS_MAX) > + goto out; > status = -ENOMEM; > rsci.cred.cr_group_info = groups_alloc(N); > if (rsci.cred.cr_group_info == NULL) > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html I touched this code relatively recently, and this check looks correct. Feel free to add Reviewed-by: Simo Sorce <simo@redhat.com> Simo. -- Simo Sorce * Red Hat, Inc * New York ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch v2] sunrpc: integer underflow in rsc_parse() 2015-02-25 3:54 ` Simo Sorce @ 2015-02-26 20:40 ` J. Bruce Fields 0 siblings, 0 replies; 3+ messages in thread From: J. Bruce Fields @ 2015-02-26 20:40 UTC (permalink / raw) To: Simo Sorce Cc: Dan Carpenter, Trond Myklebust, Anna Schumaker, David S. Miller, Jeff Layton, Kinglong Mee, linux-nfs, netdev, Eric W. Biederman, Andrew Morton, Andy Lutomirski, Wang YanQing, linux-kernel, kernel-janitors On Tue, Feb 24, 2015 at 10:54:44PM -0500, Simo Sorce wrote: > On Tue, 2015-02-24 at 18:34 +0300, Dan Carpenter wrote: > > If we call groups_alloc() with invalid values then it's might lead to > > memory corruption. For example, with a negative value then we might not > > allocate enough for sizeof(struct group_info). > > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > --- > > v2: In v1, I changed groups_alloc(). The other places which call > > groups_alloc() check the value before calling. Eric wanted that, either > > have all the callers check, or all the callers rely on groups_alloc(). > > In the end, Bruce Fields said adding the check here was probably > > reasonable. > > > > diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c > > index 224a82f..1095be9 100644 > > --- a/net/sunrpc/auth_gss/svcauth_gss.c > > +++ b/net/sunrpc/auth_gss/svcauth_gss.c > > @@ -463,6 +463,8 @@ static int rsc_parse(struct cache_detail *cd, > > /* number of additional gid's */ > > if (get_int(&mesg, &N)) > > goto out; > > + if (N < 0 || N > NGROUPS_MAX) > > + goto out; > > status = -ENOMEM; > > rsci.cred.cr_group_info = groups_alloc(N); > > if (rsci.cred.cr_group_info == NULL) > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > I touched this code relatively recently, and this check looks correct. > Feel free to add Reviewed-by: Simo Sorce <simo@redhat.com> Thanks! I thought your below-the-line context was useful, so pulled a version of it into the commit. --b. commit 76cb4be993c0 Author: Dan Carpenter <dan.carpenter@oracle.com> Date: Tue Feb 24 18:34:01 2015 +0300 sunrpc: integer underflow in rsc_parse() If we call groups_alloc() with invalid values then it's might lead to memory corruption. For example, with a negative value then we might not allocate enough for sizeof(struct group_info). (We're doing this in the caller for consistency with other callers of groups_alloc(). The other alternative might be to move the check out of all the callers into groups_alloc().) Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Simo Sorce <simo@redhat.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com> diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c index 224a82f24d3c..1095be9c80ab 100644 --- a/net/sunrpc/auth_gss/svcauth_gss.c +++ b/net/sunrpc/auth_gss/svcauth_gss.c @@ -463,6 +463,8 @@ static int rsc_parse(struct cache_detail *cd, /* number of additional gid's */ if (get_int(&mesg, &N)) goto out; + if (N < 0 || N > NGROUPS_MAX) + goto out; status = -ENOMEM; rsci.cred.cr_group_info = groups_alloc(N); if (rsci.cred.cr_group_info == NULL) ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-26 20:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150223211607.GB28635@fieldses.org>
2015-02-24 15:34 ` [patch v2] sunrpc: integer underflow in rsc_parse() Dan Carpenter
2015-02-25 3:54 ` Simo Sorce
2015-02-26 20:40 ` J. Bruce Fields
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).