From: Sabrina Dubroca <sd@queasysnail.net>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: linux.nics@intel.com, e1000-devel@lists.sourceforge.net,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net] e1000: add dummy allocator to fix race condition between mtu change and netpoll
Date: Wed, 25 Feb 2015 12:25:49 +0100 [thread overview]
Message-ID: <20150225112549.GA24089@kria> (raw)
In-Reply-To: <1424863063.2553.52.camel@jtkirshe-mobl>
2015-02-25, 03:17:43 -0800, Jeff Kirsher wrote:
> On Wed, 2015-02-25 at 12:03 +0100, Sabrina Dubroca wrote:
> > @@ -4481,6 +4489,7 @@ next_desc:
> > return cleaned;
> > }
> >
> > +
> > /**
> > * e1000_alloc_jumbo_rx_buffers - Replace used jumbo receive buffers
> > * @adapter: address of board private structure
>
> This added blank line is not needed or wanted.
Ouch, I noticed that too late. Sorry, I messed up.
Oh, BTW, e1000e has multiple allocators as well. I haven't really
looked at them yet, and I don't have any HW to test.
--
Sabrina
prev parent reply other threads:[~2015-02-25 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 11:03 [PATCH v2 net] e1000: add dummy allocator to fix race condition between mtu change and netpoll Sabrina Dubroca
2015-02-25 11:17 ` Jeff Kirsher
2015-02-25 11:25 ` Sabrina Dubroca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225112549.GA24089@kria \
--to=sd@queasysnail.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux.nics@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox