Netdev List
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Scott Feldman <sfeldma@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2] rocker: silence shift wrapping warning
Date: Wed, 25 Feb 2015 14:44:05 +0100	[thread overview]
Message-ID: <20150225134405.GG2039@nanopsycho.orion> (raw)
In-Reply-To: <20150225133612.GV19745@mwanda>

Wed, Feb 25, 2015 at 02:36:12PM CET, dan.carpenter@oracle.com wrote:
>"val" is declared as a u64 so static checkers complain that this shift
>can wrap.  I don't have the hardware but probably it's doesn't have over

It's a QEMU hardware, you can have it easily.

>31 ports.  Still we may as well silence the warning even if it's not a
>real bug.

It can have up to 62 ports.

>
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jiri Pirko <jiri@resnulli.us>

  reply	other threads:[~2015-02-25 13:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25 13:36 [patch 2/2] rocker: silence shift wrapping warning Dan Carpenter
2015-02-25 13:44 ` Jiri Pirko [this message]
2015-02-25 13:50 ` Scott Feldman
2015-02-27 20:59 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150225134405.GG2039@nanopsycho.orion \
    --to=jiri@resnulli.us \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sfeldma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox