From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Graf Subject: Re: [PATCH net 2/2] rhashtable: remove indirection for grow/shrink decision functions Date: Wed, 25 Feb 2015 17:23:28 +0000 Message-ID: <20150225172328.GB18416@casper.infradead.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, pablo@netfilter.org, johunt@akamai.com, kaber@trash.net, netdev@vger.kernel.org To: Daniel Borkmann Return-path: Received: from casper.infradead.org ([85.118.1.10]:52480 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752830AbbBYRXa (ORCPT ); Wed, 25 Feb 2015 12:23:30 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 02/25/15 at 04:31pm, Daniel Borkmann wrote: > Currently, all real users of rhashtable default their grow and shrink > decision functions to rht_grow_above_75() and rht_shrink_below_30(), > so that there's currently no need to have this explicitly selectable. > > It can/should be generic and private inside rhashtable until a real > use case pops up. Since we can make this private, we'll save us this > additional indirection layer and can improve insertion/deletion time > as well. > > Reference: http://patchwork.ozlabs.org/patch/443040/ > Suggested-by: David S. Miller > Signed-off-by: Daniel Borkmann Nice Acked-by: Thomas Graf