From: David Miller <davem@davemloft.net>
To: marzo.pedro@gmail.com
Cc: ian.campbell@citrix.com, wei.liu2@citrix.com,
xen-devel@lists.xenproject.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] xen-netback: remove compilation warning
Date: Thu, 26 Feb 2015 11:30:46 -0500 (EST) [thread overview]
Message-ID: <20150226.113046.199389136864969627.davem@davemloft.net> (raw)
In-Reply-To: <1424939141-30730-1-git-send-email-marzo.pedro@gmail.com>
From: pedro <marzo.pedro@gmail.com>
Date: Thu, 26 Feb 2015 09:25:41 +0100
> From: pmarzo <marzo.pedro@gmail.com>
>
> offset and size are of type uint16_t so the %lu gives a warning
> A %u specifier, the same used in size makes gcc happy
> Not sure if a %x would be more correct
>
> Signed-off-by: Pedro Marzo Perez <marzo.pedro@gmail.com>
This patch actually adds a warning on my machine, and your analysis
of the types is therefore probably incorrect:
drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’:
drivers/net/xen-netback/netback.c:1259:8: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 5 has type ‘long unsigned int’ [-Wformat=]
The issue is probably "~PAGE_MASK" and I think the type of that
propagates into the type of the overall calculation.
next prev parent reply other threads:[~2015-02-26 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 8:25 [PATCH 1/1] xen-netback: remove compilation warning pedro
2015-02-26 10:13 ` Wei Liu
2015-02-26 16:30 ` David Miller [this message]
2015-02-27 10:45 ` pmarzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150226.113046.199389136864969627.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ian.campbell@citrix.com \
--cc=marzo.pedro@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).