From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] net: phy: b53: switchdev driver for Broadcom BCM53xx switches Date: Thu, 26 Feb 2015 16:36:05 +0100 Message-ID: <20150226153605.GE8806@lunn.ch> References: <54ED017E.6000902@gmail.com> <20150225001534.GB15633@lunn.ch> <54ED19AB.7020003@gmail.com> <20150225140356.GB17992@lunn.ch> <20150225141945.GC17992@lunn.ch> <20150226151830.GD8806@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Florian Fainelli , Andy Gospodarek , "David S. Miller" , Network Development , Jonas Gorski , Hauke Mehrtens , Felix Fietkau , Jiri Pirko To: Rafa?? Mi??ecki Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:50304 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753954AbbBZPjJ (ORCPT ); Thu, 26 Feb 2015 10:39:09 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: > It doesn't really answer my question as I don't see functionality I'm > looking for in bcm_sf2. I don't see it handling (un)tagging or PVID > anywhere. It makes me believe such features are not implemented (and > not configurable) using bridges/dsa at all. Can you any API related to > untagging / PVID? The (un)tagging code is in net/dsa/tag_brcm.c This is generic code, so you would not expect to find it in bcm_sf2. All you need to do is set .tag_protocol = DSA_TAG_PROTO_BRCM, in your dsa_switch_driver structure and the core DSA code will ensure the packets gets the header applied/removed. Andrew