From: Vadim Kochan <vadim4j@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: vadim4j@gmail.com, stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 v4] lib: Replace 16384 netlink buf size by macro
Date: Fri, 27 Feb 2015 19:47:31 +0200 [thread overview]
Message-ID: <20150227174731.GA6949@angus-think.wlc.globallogic.com> (raw)
In-Reply-To: <20150227.123831.436431838595846209.davem@davemloft.net>
On Fri, Feb 27, 2015 at 12:38:31PM -0500, David Miller wrote:
> From: Vadim Kochan <vadim4j@gmail.com>
> Date: Fri, 27 Feb 2015 08:31:40 +0200
>
> > From: Vadim Kochan <vadim4j@gmail.com>
> >
> > Replaced hard coded 16384 netlink buffer size by NLBUF_SIZE,
> > which can be overridden by -DNLBUF_SIZE.
> >
> > Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
>
> I would like to know what problem is solved by changing this to
> any other value?
>
> And then I would like to know why other potential solutions to
> this problem were not considered, such as making the buffer size
> dynamic and run-time selectable, perhaps with a size choosen
> in a manner to avoid whatever problem you hit with the current
> size.
Its just for the case when it might be changed in the future then it can be
easy found and changed. Just reject it if it looks useless. About
dynamic changing I think it makes sense to do it because memset is used
on the each netlink 16384 sized msg.
next prev parent reply other threads:[~2015-02-27 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 6:31 [PATCH iproute2 v4] lib: Replace 16384 netlink buf size by macro Vadim Kochan
2015-02-27 17:38 ` David Miller
2015-02-27 17:47 ` Vadim Kochan [this message]
2015-02-28 3:01 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150227174731.GA6949@angus-think.wlc.globallogic.com \
--to=vadim4j@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox