From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2 4/7] net: packet: use skb->dev as storage for skb orig len instead of skb->cb[] Date: Sat, 28 Feb 2015 14:21:35 -0500 (EST) Message-ID: <20150228.142135.470339626705046722.davem@davemloft.net> References: <1424977624-649-1-git-send-email-eyal.birger@gmail.com> <1424977624-649-5-git-send-email-eyal.birger@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: willemb@google.com, edumazet@google.com, shmulik.ladkani@gmail.com, linux-bluetooth@vger.kernel.org, marcel@holtmann.org, netdev@vger.kernel.org To: eyal.birger@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:33775 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbbB1TVj (ORCPT ); Sat, 28 Feb 2015 14:21:39 -0500 In-Reply-To: <1424977624-649-5-git-send-email-eyal.birger@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Eyal Birger Date: Thu, 26 Feb 2015 21:07:01 +0200 > As part of an effort to move skb->dropcount to skb->cb[], 4 bytes > of additional room are needed in skb->cb[] in packet sockets. > > Store the skb original length in skb->dev instead of skb->cb[] for > this purpose. > > Signed-off-by: Eyal Birger I'm a little confused, why is this even needed? packet_skb_cb is 24 bytes by my calculations, which is much smaller than the cb[] size which is 48 bytes.