From: David Miller <davem@davemloft.net>
To: ben.hutchings@codethink.co.uk
Cc: netdev@vger.kernel.org, oliver@neukum.org,
linux-kernel@codethink.co.uk, linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next] usbnet: Fix tx_packets stat for FLAG_MULTI_FRAME drivers
Date: Sat, 28 Feb 2015 14:28:01 -0500 (EST) [thread overview]
Message-ID: <20150228.142801.274701022130750604.davem@davemloft.net> (raw)
In-Reply-To: <1424979277.4444.39.camel@xylophone.i.decadent.org.uk>
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
Date: Thu, 26 Feb 2015 19:34:37 +0000
> Currently the usbnet core does not update the tx_packets statistic for
> drivers with FLAG_MULTI_PACKET and there is no hook in the TX
> completion path where they could do this.
>
> cdc_ncm and dependent drivers are bumping tx_packets stat on the
> transmit path while asix and sr9800 aren't updating it at all.
>
> Add a packet count in struct skb_data so these drivers can fill it
> in, initialise it to 1 for other drivers, and add the packet count
> to the tx_packets statistic on completion.
>
> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Applied, thanks Ben.
prev parent reply other threads:[~2015-02-28 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 19:34 [PATCH net-next] usbnet: Fix tx_packets stat for FLAG_MULTI_FRAME drivers Ben Hutchings
[not found] ` <1424979277.4444.39.camel-2NU49sBE5Aze9VDwLV8dzJPsBRI6B4nW9dF7HbQ/qKg@public.gmane.org>
2015-02-27 8:50 ` Bjørn Mork
2015-02-28 19:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150228.142801.274701022130750604.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben.hutchings@codethink.co.uk \
--cc=linux-kernel@codethink.co.uk \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).