From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: eyal.birger-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: willemb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
shmulik.ladkani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH net-next v3 0/7] net: move skb->dropcount to skb->cb[]
Date: Mon, 02 Mar 2015 00:20:00 -0500 (EST) [thread overview]
Message-ID: <20150302.002000.2074179681664043670.davem@davemloft.net> (raw)
In-Reply-To: <1425214711-9562-1-git-send-email-eyal.birger-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
From: Eyal Birger <eyal.birger-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Sun, 1 Mar 2015 14:58:24 +0200
> Commit 977750076d98 ("af_packet: add interframe drop cmsg (v6)")
> unionized skb->mark and skb->dropcount in order to allow recording
> of the socket drop count while maintaining struct sk_buff size.
>
> skb->dropcount was introduced since there was no available room
> in skb->cb[] in packet sockets. However, its introduction led to
> the inability to export skb->mark to userspace.
>
> It was considered to alias skb->priority instead of skb->mark.
> However, that would lead to the inabilty to export skb->priority
> to userspace if desired. Such change may also lead to hard-to-find
> issues as skb->priority is assumed to be alias free, and, as noted
> by Shmulik Ladkani, is not 'naturally orthogonal' with other skb
> fields.
>
> This patch series follows the suggestions made by Eric Dumazet moving
> the dropcount metric to skb->cb[], eliminating this problem
> at the expense of 4 bytes less in skb->cb[] for protocol families
> using it.
>
> The patch series include compactization of bluetooth and packet
> use of skb->cb[] as well as the infrastructure for placing dropcount
> in skb->cb[].
Ok, I think I can live with this.
Series applied, thanks.
prev parent reply other threads:[~2015-03-02 5:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 12:58 [PATCH net-next v3 0/7] net: move skb->dropcount to skb->cb[] Eyal Birger
2015-03-01 12:58 ` [PATCH net-next v3 2/7] net: bluetooth: compact struct bt_skb_cb by converting boolean fields to bit fields Eyal Birger
2015-03-01 12:58 ` [PATCH net-next v3 4/7] net: packet: use sockaddr_ll fields as storage for skb original length in recvmsg path Eyal Birger
2015-03-01 12:58 ` [PATCH net-next v3 6/7] net: add common accessor for setting dropcount on packets Eyal Birger
[not found] ` <1425214711-9562-1-git-send-email-eyal.birger-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-01 12:58 ` [PATCH net-next v3 1/7] net: bluetooth: compact struct bt_skb_cb by inlining struct hci_req_ctrl Eyal Birger
2015-03-01 12:58 ` [PATCH net-next v3 3/7] net: rxrpc: change call to sock_recv_ts_and_drops() on rxrpc recvmsg to sock_recv_timestamp() Eyal Birger
2015-03-01 12:58 ` [PATCH net-next v3 5/7] net: use common macro for assering skb->cb[] available size in protocol families Eyal Birger
2015-03-01 12:58 ` [PATCH net-next v3 7/7] net: move skb->dropcount to skb->cb[] Eyal Birger
2015-03-02 5:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302.002000.2074179681664043670.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=eyal.birger-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shmulik.ladkani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=willemb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).