From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: gregory.v.rose@intel.com, netdev@vger.kernel.org,
nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com
Subject: Re: [net-next] i40e: Fix dependencies in the i40e driver on configfs
Date: Tue, 03 Mar 2015 15:45:15 -0500 (EST) [thread overview]
Message-ID: <20150303.154515.1426526534548261925.davem@davemloft.net> (raw)
In-Reply-To: <1425415135-10257-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 3 Mar 2015 12:38:55 -0800
> From: Greg Rose <gregory.v.rose@intel.com>
>
> Module dependencies are broken in the case where CONFIG_I40E=y and
> CONFIG_CONFIGFS_FS=m. This fixes the broken dependency.
>
> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
This doesn't fix anything, nothing tests I40E_CONFIGFS_FS:
[davem@abraco net-next]$ make -s -j8
scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
kernel/Makefile:133: *** No X.509 certificates found ***
kernel/Makefile:133: *** No X.509 certificates found ***
drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
i40e_configfs.c:(.text+0x192db7): undefined reference to `config_item_init_type_name'
drivers/built-in.o: In function `i40e_configfs_init':
(.text+0x192df1): undefined reference to `config_group_init'
drivers/built-in.o: In function `i40e_configfs_init':
(.text+0x192e25): undefined reference to `configfs_register_subsystem'
drivers/built-in.o: In function `i40e_configfs_exit':
(.text+0x192e7a): undefined reference to `configfs_unregister_subsystem'
make: *** [vmlinux] Error 1
[davem@abraco net-next]$ git am --signoff diff
Applying: i40e: Fix dependencies in the i40e driver on configfs
[davem@abraco net-next]$ make oldconfig
scripts/kconfig/conf --oldconfig Kconfig
#
# configuration written to .config
#
[davem@abraco net-next]$ make -s -j8
scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
kernel/Makefile:133: *** No X.509 certificates found ***
kernel/Makefile:133: *** No X.509 certificates found ***
drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
i40e_configfs.c:(.text+0x192db7): undefined reference to `config_item_init_type_name'
drivers/built-in.o: In function `i40e_configfs_init':
(.text+0x192df1): undefined reference to `config_group_init'
drivers/built-in.o: In function `i40e_configfs_init':
(.text+0x192e25): undefined reference to `configfs_register_subsystem'
drivers/built-in.o: In function `i40e_configfs_exit':
(.text+0x192e7a): undefined reference to `configfs_unregister_subsystem'
make: *** [vmlinux] Error 1
[davem@abraco net-next]$
next prev parent reply other threads:[~2015-03-03 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 20:38 [net-next] i40e: Fix dependencies in the i40e driver on configfs Jeff Kirsher
2015-03-03 20:42 ` Jeff Kirsher
2015-03-03 20:45 ` David Miller [this message]
2015-03-03 21:04 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303.154515.1426526534548261925.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox