From: David Miller <davem@davemloft.net>
To: alexander.h.duyck@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next PATCH v2 0/8] ipv4/fib_trie: Cleanups to prepare for introduction of key vector
Date: Wed, 04 Mar 2015 23:37:08 -0500 (EST) [thread overview]
Message-ID: <20150304.233708.2028588703939561424.davem@davemloft.net> (raw)
In-Reply-To: <20150304225459.1612.45514.stgit@ahduyck-vm-fedora20>
From: Alexander Duyck <alexander.h.duyck@redhat.com>
Date: Wed, 04 Mar 2015 14:57:55 -0800
> This patch series is meant to mostly just clean up the fib_trie to prepare
> it for the introduction of the key_vector. As such there are a number of
> minor clean-ups such as reformatting the tnode to match the format once the
> key vector is introduced, some optimizations to drop the need for a leaf
> parent pointer, and some changes to remove duplication of effort such as
> the 2 look-ups that were essentially being done per node insertion.
>
> v2: Added code to cleanup idx >> n->bits and explain unsigned long logic
> Added code to prevent allocation when tnode size is larger than size_t
Looks good, series applied, thanks Alex.
prev parent reply other threads:[~2015-03-05 4:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 22:57 [net-next PATCH v2 0/8] ipv4/fib_trie: Cleanups to prepare for introduction of key vector Alexander Duyck
2015-03-04 22:58 ` [net-next PATCH v2 1/8] fib_trie: Only resize tnodes once instead of on each leaf removal in fib_table_flush Alexander Duyck
2015-03-04 22:59 ` [net-next PATCH v2 2/8] fib_trie: Fib walk rcu should take a tnode and key instead of a trie and a leaf Alexander Duyck
2015-03-04 23:01 ` [net-next PATCH v2 3/8] fib_trie: Fib find node should return parent Alexander Duyck
2015-03-04 23:02 ` [net-next PATCH v2 4/8] fib_trie: Update insert and delete to make use of tp from find_node Alexander Duyck
2015-03-04 23:02 ` [net-next PATCH v2 5/8] fib_trie: move leaf and tnode to occupy the same spot in the key vector Alexander Duyck
2015-03-04 23:02 ` [net-next PATCH v2 6/8] fib_trie: Make fib_table rcu safe Alexander Duyck
2015-03-04 23:04 ` [net-next PATCH v2 7/8] fib_trie: Update last spot w/ idx >> n->bits code and explanation Alexander Duyck
2015-03-04 23:04 ` [net-next PATCH v2 8/8] fib_trie: Prevent allocating tnode if bits is too big for size_t Alexander Duyck
2015-03-05 4:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304.233708.2028588703939561424.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox