* [PATCH 1/1] bnx2x: Force fundamental reset for EEH recovery
@ 2015-03-04 14:09 Brian King
2015-03-05 20:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Brian King @ 2015-03-04 14:09 UTC (permalink / raw)
To: ariel.elior; +Cc: netdev, cascardo, brking, stable
EEH recovery for bnx2x based adapters is not reliable on all Power
systems using the default hot reset, which can result in an
unrecoverable EEH error. Forcing the use of fundamental reset
during EEH recovery fixes this.
Cc: stable<stable@vger.kernel.org>
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 3 +++
1 file changed, 3 insertions(+)
diff -puN drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c~bnx2x_needs_freset drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
--- linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c~bnx2x_needs_freset 2015-03-03 08:46:09.281961703 -0600
+++ linux-bjking1/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c 2015-03-03 08:46:09.287961639 -0600
@@ -12722,6 +12722,9 @@ static int bnx2x_init_dev(struct bnx2x *
pci_write_config_dword(bp->pdev, PCICFG_GRC_ADDRESS,
PCICFG_VENDOR_ID_OFFSET);
+ /* Set PCIe reset type to fundamental for EEH recovery */
+ pdev->needs_freset = 1;
+
/* AER (Advanced Error reporting) configuration */
rc = pci_enable_pcie_error_reporting(pdev);
if (!rc)
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] bnx2x: Force fundamental reset for EEH recovery
2015-03-04 14:09 [PATCH 1/1] bnx2x: Force fundamental reset for EEH recovery Brian King
@ 2015-03-05 20:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-03-05 20:38 UTC (permalink / raw)
To: brking; +Cc: ariel.elior, netdev, cascardo, stable
From: Brian King <brking@linux.vnet.ibm.com>
Date: Wed, 04 Mar 2015 08:09:44 -0600
> EEH recovery for bnx2x based adapters is not reliable on all Power
> systems using the default hot reset, which can result in an
> unrecoverable EEH error. Forcing the use of fundamental reset
> during EEH recovery fixes this.
>
> Cc: stable<stable@vger.kernel.org>
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Applied, thanks Brian.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-05 20:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-04 14:09 [PATCH 1/1] bnx2x: Force fundamental reset for EEH recovery Brian King
2015-03-05 20:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).