From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] inet_diag: remove duplicate code from inet_twsk_diag_dump()
Date: Thu, 05 Mar 2015 22:55:18 -0500 (EST) [thread overview]
Message-ID: <20150305.225518.263646702699262144.davem@davemloft.net> (raw)
In-Reply-To: <1425579494.5130.254.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 05 Mar 2015 10:18:14 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> timewait sockets now share a common base with established sockets.
>
> inet_twsk_diag_dump() can use inet_diag_bc_sk() instead of duplicating
> code, granted that inet_diag_bc_sk() does proper userlocks
> initialization.
>
> twsk_build_assert() will catch any future changes that could break
> the assumptions.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
This looks fine, thanks Eric.
prev parent reply other threads:[~2015-03-06 3:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 18:18 [PATCH net-next] inet_diag: remove duplicate code from inet_twsk_diag_dump() Eric Dumazet
2015-03-06 3:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305.225518.263646702699262144.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).