From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: ebiederm@xmission.com, teg@jklm.no, dh.herrmann@gmail.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] ax25: remove unneeded NULL test in ax_xmit()
Date: Fri, 06 Mar 2015 01:03:56 -0500 (EST) [thread overview]
Message-ID: <20150306.010356.1391961581224590724.davem@davemloft.net> (raw)
In-Reply-To: <20150305174846.GA17072@mwanda>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 5 Mar 2015 20:48:46 +0300
> We get a static checker warning here on devel kernels:
>
> drivers/net/hamradio/mkiss.c:560 ax_xmit()
> warn: variable dereferenced before check 'skb' (see line 532)
>
> It turns out that the NULL check can be deleted.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
prev parent reply other threads:[~2015-03-06 6:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 17:48 [patch -next] ax25: remove unneeded NULL test in ax_xmit() Dan Carpenter
2015-03-06 6:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306.010356.1391961581224590724.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=dh.herrmann@gmail.com \
--cc=ebiederm@xmission.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=teg@jklm.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).